vf_vapoursynth: remove excessive locking when reading/writing frames #6262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not so sure about 2nd one (writing), because we probably need to protect "img" from being deleted from "p->buffered". Anyway it works in real tests w/o crashes. |
|
Somebody please take a look! W/o this one it's impossible to watch 4K/10bit with a real time motion interpolation. |
|
@chainikdn sorry for not being able to get to this earlier, but since you're a first time contributor could you please add the note to your PR that you agree with the licensing? See https://github.com/mpv-player/mpv/blob/master/.github/PULL_REQUEST_TEMPLATE for the sentence. |
|
@jeeb first message edited |
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Single-threaded data copying becomes a real performance bottleneck in case of 4K, especially with 10 bit color depth and high frame rates.
I agree that my changes can be relicensed to LGPL 2.1 or later.