Skip to content

fix: add error when destroying stream to generate close event even when the network connection is down #713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: add error when destroying stream to generate close event even when the network connection is down #713

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
34873ca
Add error when destroying stream to generate close event even when th…
Nov 7, 2017
177120e
Merge branch 'master' into add-destroy-error
robertsLando Jun 27, 2023
fccb81d
fix: add comment
robertsLando Jun 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/client.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1155,7 +1155,8 @@ MqttClient.prototype._cleanUp = function (forced, done) {
flush(this.outgoing)
}
debug('_cleanUp :: (%s) :: destroying stream', this.options.clientId)
this.stream.destroy()
// pass an error here to be sure the 'error' event is emitted on stream, fixes #713
this.stream.destroy(new Error('stream forcefully closed by the client'))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test that reproduces the issue

} else {
const packet = xtend({ cmd: 'disconnect' }, opts)
debug('_cleanUp :: (%s) :: call _sendPacket with disconnect packet', this.options.clientId)
Expand Down