refactor: sin logic #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
mrdav30
commented
Mar 10, 2025
mrdav30
commented
- switched to using Chebyshev-polynomial-based approximation over Taylor-series expansion for deriving Sin
- renamed static fixed-point values for clarity
- cleanup unneccessary extensions
- switched to using Chebyshev-polynomial-based approximation over Taylor-series expansion
mrdav30
added a commit
that referenced
this pull request
Mar 11, 2025
* feat: add method to extract up direction from 4x4 matrix - cleanup unneccessary extensions * feat: add method to clamp Vector3d by magnitude * task: cleanup unit tests * fix: sin accuracy - switched to using Chebyshev-polynomial-based approximation over Taylor-series expansion * refactor: rename critical static fixed values * fix: static Fixed64 const values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.