Inconsistent layout in aomap_fragment include, compared to i.e. roughnessmap_fragment

[kristiker]

Description

I want to modify he occlusion value using my own custom logic. But the ambientOcclusion variable is defined very late on the shader.

I think the aomap_fragment.js file could be simplified like below:

Solution

In case of USE_AOMAP being false, the multiplication by 1.0 for the extra operations should be insignificant.

As for computeSpecularOcclusion, I don't know where that would go.

Alternatives

I store temp variable early on, and modify the aomap_fragment chunk in a messy way.

Additional context

I am using this tool: https://ycw.github.io/three-shaderlib-skim/dist/#/latest/standard/fragment

[Mugen87]

I'm afraid it is not clear what you are suggesting. Please do never use screenshots to explain code changes. It's better to implement them in a branch and then share the commit. In this way, we can easier see the diff.

[kristiker]

Sure, I might get to it soon. Edit: There you go @Mugen87 5fae13b

[Mugen87]

TBH, I don't see how this commit is an improvement. It makes the code actually harder to read since the AO-related logic now leaks into a chunk where it does not belong.

Sorry, but you need to find a solution for this on app level.