Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

potential leak while disposing WebGLRenderer #8987

Closed
4 of 11 tasks
olivierchatry opened this issue May 25, 2016 · 3 comments
Closed
4 of 11 tasks

potential leak while disposing WebGLRenderer #8987

olivierchatry opened this issue May 25, 2016 · 3 comments

Comments

@olivierchatry
Copy link
Contributor

olivierchatry commented May 25, 2016 •
edited
Loading

Description of the problem

Hello,

My software is switch between two renderer (threejs / own SVG renderer ), removing the gl context while swapping renderer. While profiling for leaks, I noticed that two arrays in Three WebGLRenderer are not cleared when I call dispose on the context, namely opaquesObject and transparentsObject.

https://github.com/mrdoob/three.js/blob/master/src/renderers/WebGLRenderer.js#L27

My workaround is to render an empty scene, so that they get cleared by the rendering, but it would be better if "dispose" actually clear them.

Hope I am clear enough, but if you need more information, do not hesitate

Three.js version
  • Dev
  • r77
  • [ x] ...
Browser
  • All of them
  • Chrome
  • Firefox
  • Internet Explorer
OS
  • All of them
  • Windows
  • Linux
  • Android
  • IOS
Hardware Requirements (graphics card, VR Device, ...)
@mrdoob
Copy link
Owner

mrdoob commented May 25, 2016

Sounds good. Would you like to do a Pull Request?

@olivierchatry
Copy link
Contributor Author

Sure !

olivierchatry pushed a commit to olivierchatry/three.js that referenced this issue May 25, 2016
Clear opaque and transparent array in WebGLRenderer.dispose (mrdoob#8987
e388650 
)
olivierchatry pushed a commit to olivierchatry/three.js that referenced this issue May 26, 2016
Clear opaque and transparent array in WebGLRenderer.dispose (mrdoob#…
513fa23 
…8987)
mrdoob pushed a commit that referenced this issue May 27, 2016
@olivierchatry @mrdoob
Clear opaque and transparent array in WebGLRenderer.dispose (#8987) (#…
8887aa0 
…9011)
@olivierchatry olivierchatry mentioned this issue Nov 19, 2017
Closed
@Mugen87
Copy link
Collaborator

Mugen87 commented Feb 13, 2018 •
edited
Loading

This PR should solve the issue: #13122

opaqueObjects and transparentObjects are properties of WebGLRenderList now.

@Mugen87 Mugen87 closed this as completed Feb 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mrdoob @olivierchatry @Mugen87