Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ColladaLoader: Removed usage of alpha maps. #13801

Merged
merged 1 commit into from
Apr 8, 2018
Merged

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Apr 8, 2018

See discussion in #13792

We are not allowed to interpret the texture of a <transparent> tag as an alpha map.

@gymadarasz This PR actually fixes your model. At least on my computer.

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Apr 8, 2018

image

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Apr 8, 2018

@gymadarasz BTW: You should decrease the shininess values of the materials. If you apply values of 30, she looks like:
image

@gymadarasz
Copy link

Yeah she is definitely looks much more fancy :) 👍
Thanks

@mrdoob mrdoob added this to the r92 milestone Apr 8, 2018
@mrdoob mrdoob merged commit 566d784 into mrdoob:dev Apr 8, 2018
@mrdoob
Copy link
Owner

mrdoob commented Apr 8, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants