Box3: Fixed bug in .intersectsPlane(). #14836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mugen87
requested changes
Sep 3, 2018
src/math/Box3.js
Outdated
| @@ -384,7 +384,7 @@ Object.assign( Box3.prototype, { | |||
|
|
|||
| } | |||
|
|
|||
| return ( min <= plane.constant && max >= plane.constant ); | |||
| return ( min <= -plane.constant && max >= -plane.constant ); | |||
There was a problem hiding this comment.
Please insert a space after the signs. Otherwise the linter won't be happy...
There was a problem hiding this comment.
Thank you for your remind. Whitespaces added.
Mugen87
approved these changes
Sep 3, 2018
Mugen87
changed the title
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add two negative sign before both of the plane.constant and update the unit test
Fixes #14834