WebGLTextures: CubeTexture from CompressedTextures signature bug #16648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mugen87
approved these changes
Jun 2, 2019
Mugen87
changed the title
|
Thanks! |
|
I'm afraid this change broke webgl_loader_texture_dds. Check out the console logs.
@oguzeroglu Do you mind having a look at this? |
|
For now, let's revert the PR. We can't make a change when examples break with runtime errors. |
|
@Mugen87 thanks for the feedback! I'll investigate this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue explained here: #16584
Discussed here: https://discourse.threejs.org/t/three-cubetexture-using-three-compressedtexture/7868