Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove SSAOPass.quad.dispose #18149

Merged
merged 2 commits into from
Dec 13, 2019
Merged

remove SSAOPass.quad.dispose #18149

merged 2 commits into from
Dec 13, 2019

Conversation

drcmda
Copy link
Contributor

@drcmda drcmda commented Dec 13, 2019 •
edited by mrdoob
Loading

There is no this.quad, neither in SSAOPass, nor in Pass. Must have been a left-over.

Fixes #18148

@Mugen87
Copy link
Collaborator

Mugen87 commented Dec 13, 2019

Please change the js version and then run node utils/modularize.js. Otherwise one of the next PRs will accidentally revert your change.

@Mugen87 Mugen87 merged commit 2b8654c into mrdoob:dev Dec 13, 2019
@Mugen87 Mugen87 added this to the r112 milestone Dec 13, 2019
@drcmda drcmda deleted the ssaop branch December 13, 2019 14:30
@mrdoob
Copy link
Owner

mrdoob commented Dec 13, 2019

Thanks!

@mrdoob mrdoob changed the title remove SSAOPass.quad.dispose, fixes #18148 remove SSAOPass.quad.dispose Dec 13, 2019
@mrdoob mrdoob mentioned this pull request Dec 13, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r112
Development

Successfully merging this pull request may close these issues.

SSAOPass.dispose() broken
3 participants
@drcmda @Mugen87 @mrdoob