WebGPURenderer: Detect needsBindGroupRefresh more properly #20272
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR lets
WebGPURenderer
detectneedsBindGroupRefresh
more properly.Problem this PR fixes
Renderer seems to have overlooked a case where texture is shared in multiple materials. Currently it determines whether bind group refresh is necessary or not just with comparing texture version and GPU texture version. But it doesn't work correctly if texture is shared in multiple materials. The second or later materials can't detect
needsBindGroupRefresh
because when they check the GPU texture version it has been already updated by the first material.Solution
An easy solution would be comparing bind group's GPU texture with the one in texture property managed by
WebGPUTextures
. Refer to the code for detail.Without this change. (An example many materials use the same texture.)
With this change.