WebGPURenderer: Initial color blending #20275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this is a good start! |
Mugen87
approved these changes
Sep 6, 2020
|
I'll merge for further testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an initial color blending support to
WebGPURenderer.Screenshot of opaque and transparent objects in a scene (with #20272 and #20274).
You might like to wait for basic node based material system, but I think basic color blending logic won't change so much (other than shader code) even with node based material system. And the change is just about +50 lines and the code isn't so complex. I think it would be good for us that we can start color blending test with this small change.
What do you think?