WebXRManager: Use async/await in setSession(). #20754
Conversation
|
Oh,
Looks like @marcofugaro Any ideas 😇? It's the first time the core uses async/await. |
|
@Mugen87 I'll look into it! |
|
@mrdoob Without this change, three.js experiences will start failing as soon as Chrome 88 ships. |
|
@Mugen87 it seems this PR is still failing. Are you looking into fixing it? |
Yes. I'm on it 😊 . |
|
Okay, the problem is that It is required so babel can correctly transpile the code for the build files |
|
Just voicing my concern as well that this is able to land quickly. Happy to contribute directly if I can, though I'm not familiar with the blocking dependency. |
|
Thanks! |
|
Thank you! |
setSession should return Promise<void> instead of void since r125 See: mrdoob/three.js#20754
setSession should return Promise<void> instead of void since r125 See: mrdoob/three.js#20754
setSession should return Promise<void> instead of void since r125 See: mrdoob/three.js#20754
* fix (three): update WebXRManager getReferenceSpace / getSession should be nullable * fix (three): Update WebXRManager setSession should return Promise<void> instead of void since r125 See: mrdoob/three.js#20754 * fix (three): Update WebXRManager Trivial rename of arguments * test (three): add a test webxr-vr-cube.ts, a simple example featuring WebXR VR * fix (three): Update XRSession XRSession should extend EventTarget * chore (three): Modify tsconfig.json Forgot to add `webxr-vr-cube.ts` to the tsconfig.json * docs: add FMS-Cat as a contributor * refactor: ran prettier:write
Related issue: Fixed #20715.
Description
@ranbuch Do you mind testing this change? I've tried it with an Oculus Quest and it seems to work.