Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing Oculus hands rendering broken by recent WebXR Hands API change #21712

Merged
merged 8 commits into from
May 6, 2021
Merged

Fixing Oculus hands rendering broken by recent WebXR Hands API change #21712

merged 8 commits into from
May 6, 2021

Conversation

felixtrz
Copy link
Contributor

@felixtrz felixtrz commented Apr 23, 2021 •
edited by Mugen87
Loading

Fixing oculus hands broken by recent WebXR Hands API change by Oculus Browser.
Disabling low poly option in handinput - profile example until a up-to-date low poly model is available

Fixed #21666.

@felixtrz felixtrz changed the title Unbreakhands Fixing Oculus hands rendering broken by recent WebXR Hands API change Apr 23, 2021
@Mugen87
Copy link
Collaborator

Mugen87 commented Apr 24, 2021

I guess that would fix #21666, right?

@mrdoob
Copy link
Owner

mrdoob commented Apr 24, 2021

Nice! Would it be possible to make glb files instead of fbx though?

@felixtrz
Copy link
Contributor Author

I guess that would fix #21666, right?

Yes it will

@Mugen87 Mugen87 added this to the r129 milestone Apr 26, 2021
@felixtrz
Copy link
Contributor Author

Nice! Would it be possible to make glb files instead of fbx though?

We do have glb files, I kept the fbx because the hand model files in the repo were all fbx. Let me change that, it'll be a quick fix

@Mugen87
Copy link
Collaborator

Mugen87 commented Apr 26, 2021 •
edited
Loading

Do you mind creating the screenshots for the new examples (so the E2E test work)? You can use these commands:

npm run make-screenshot webxr_vr_handinput_pointerclick
npm run make-screenshot webxr_vr_handinput_pointerdrag
npm run make-screenshot webxr_vr_handinput_pressbutton

Mugen87
Mugen87 previously approved these changes Apr 26, 2021
View reviewed changes
@felixtrz felixtrz mentioned this pull request Apr 26, 2021
Closed
@Mugen87 Mugen87 mentioned this pull request Apr 28, 2021
Closed
@Mugen87
Copy link
Collaborator

Mugen87 commented May 4, 2021

Tested the new examples on a Quest 2 today. Really awesome!

@Mugen87 Mugen87 dismissed their stale review May 4, 2021 13:15

More feedback required.

@jameshdougherty jameshdougherty mentioned this pull request May 4, 2021
Closed
@felixtrz
Copy link
Contributor Author

felixtrz commented May 6, 2021

  1. Updated existing and new samples to fetch models from webxr input profile cdn
  2. Removed old fbx and glb models
  3. Removed redundant implementation of XRHandMeshModel

@mrdoob mrdoob merged commit 29dd217 into mrdoob:dev May 6, 2021
@mrdoob
Copy link
Owner

mrdoob commented May 6, 2021

Thanks!

@mrdoob
Copy link
Owner

mrdoob commented May 6, 2021

Bug fix: a92265f

@mrdoob
Copy link
Owner

mrdoob commented May 6, 2021

Minor: 9bbd837

@Mugen87 Mugen87 mentioned this pull request May 6, 2021
Merged
@mrdoob
Copy link
Owner

mrdoob commented May 6, 2021

Bug fix: 2c9b143

@mrdoob
Copy link
Owner

mrdoob commented May 6, 2021

Seems like the code had not been tested.
I've fixed it and made sure it works on the Quest: 571347f

mrdoob
mrdoob reviewed May 6, 2021
View reviewed changes
examples/jsm/webxr/XRHandModelFactory.js
Comment on lines -80 to +95
handModel.motionController = new XRHandOculusMeshModel( handModel, controller, this.path, xrInputSource.handedness, options );
fetchProfile(xrInputSource, DEFAULT_PROFILES_PATH, DEFAULT_PROFILE).then(({ profile, assetPath }) => {

handModel.motionController = new XRHandMeshModel( handModel, controller, assetPath);

}).catch((err) => {

console.warn(err);

});
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fe1ixz I reverted this code. Why do we need to call fetchProfile? 🤔

@Mugen87 Mugen87 mentioned this pull request May 6, 2021
Merged
@stewdio
Copy link
Contributor

stewdio commented May 7, 2021

(You all are amazing! I am so excited to finally update this old sign language demo from last summer once these joint orientation fixes are out!)

@stewdio stewdio mentioned this pull request May 7, 2021
Closed
@joshuaellis joshuaellis mentioned this pull request May 8, 2021
Closed
11 tasks
@stewdio
Copy link
Contributor

stewdio commented May 24, 2021

Slight tangent: I saw the Text2D file now included in the WebXR folder. Would something like SurfaceText be of interest? If so, I could clean it up and submit. https://github.com/stewdio/handy.js/blob/master/vendor/Moar/scripts/SurfaceText.js I even have a version kicking around somewhere that handles line wraps.

@Mugen87 Mugen87 mentioned this pull request Dec 30, 2021
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrdoob mrdoob mrdoob left review comments

@Mugen87 Mugen87 Mugen87 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r129
Development

Successfully merging this pull request may close these issues.

VR - Oculus Quest 2 hand-bone orientation changes
4 participants
@felixtrz @Mugen87 @mrdoob @stewdio