-
-
Notifications
You must be signed in to change notification settings - Fork 35.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Material: Remove skinning. #21788
Material: Remove skinning. #21788
Conversation
Sweet! So much red! 😀 |
Thanks! |
Oh, cool. Will old applications/configuration files that have |
It is just deprecated. |
Yes. It's not possible to retain this flexibility. However, the user should achieve the same result by just creating an instance of |
The last comment on #19912 (comment) ties the failure with Does this change also fix that? |
Yes, I think so. |
Fixed #20318.
Fixed #19912.
Description
This PR changes how skinning in
three.js
works. Similar toInstancedMesh
which enables instanced rendering,SkinnedMesh
enables skinning. A separate material property is not necessary anymore. This simplifies the code and also fixes conceptual issues in context of override materials and post processing.More details in #18533 (comment).