LineMaterial: Refactor GLSL. #22726
Merged
LineMaterial: Refactor GLSL. #22726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ping @gkjohnson |
gkjohnson
approved these changes
Oct 25, 2021
|
Thanks! |
|
@Mugen87 Thanks a lot, this was really fast - it's already part of r134! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: https://discourse.threejs.org/t/warning-output-of-vertex-shader-worldstart-not-read-by-fragment-shader/31125
Description
Depending on how
LineMaterialis configured, the following warnings can occur:The PR fixes these warnings by introducing some
#ifdefstatements so varyings are only defined if they are actually required.