lint: add browser compat check #23763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodyJasonBennett
added a commit
to CodyJasonBennett/three.js
that referenced
this pull request
Mar 22, 2022
See lint output in mrdoob#23763 (comment)
CodyJasonBennett
force-pushed
the
lint-browser-compat
branch
from
7dce8aa
to
d9b0016
Compare
|
Awesome, thanks! Maybe we could put |
|
Thanks! |
Merged
abernier
pushed a commit
to abernier/three.js
that referenced
this pull request
Sep 16, 2022
* lint: add browser compat check * WebGLTextures: disable compat warning for OffscreenCanvas * WebGL: disable compat warning for WebGL2 capabilities
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #23480
Description
Adds
eslint-plugin-compatto lint syntax usage in compliance with browser/environment support.I have this configured via
browserslistaccording to the babel config I shared in #23480 (comment). This can be fine-tuned for Safari, Node, etc.Console output
GitHub annotations