GLTFLoader: Allow json objects #24801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull requests will additionally allow you to pass through parsed json objects rather than only Buffers and strings. mrdoob#24764
takahirox
reviewed
Oct 15, 2022
|
Thanks for the PR. Please update https://threejs.org/docs/#examples/en/loaders/GLTFLoader.parse |
donmccurdy
approved these changes
Oct 17, 2022
I'll merge and update the docs. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #24764
Description
Instead to only using buffers and strings, this pull request will also enable you to pass along parsed json objects.