Docs: Clean up. #24808
Merged
Docs: Clean up. #24808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mugen87
commented
Oct 17, 2022
| @@ -222,13 +222,13 @@ <h3>[method:this setKTX2Loader]( [param:KTX2Loader ktx2Loader] )</h3> | |||
|
|
|||
| <h3>[method:undefined parse]( [param:ArrayBuffer data], [param:String path], [param:Function onLoad], [param:Function onError] )</h3> | |||
| <p> | |||
| [page:ArrayBuffer data] — glTF asset to parse, as an ArrayBuffer or `JSON` string.<br /> | |||
| [page:ArrayBuffer data] — glTF asset to parse, as an `ArrayBuffer`, `JSON` string or object.<br /> | |||
There was a problem hiding this comment.
Sidenote: The documentation is currently not able to parse multi-type definitions. So something like [page:ArrayBuffer|String|Object data]. Could be useful to update docs/page.js to support such definitions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #24801
Description
Updated
GLTFLoader.parse()to reflect the changes of #24801