Change other geometry defaults to match blender #25086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mugen87
reviewed
Dec 6, 2022
Mugen87
approved these changes
Dec 20, 2022
0b5vr
added a commit
to three-types/three-ts-types
that referenced
this pull request
Dec 27, 2022
joshuaellis
added a commit
to three-types/three-ts-types
that referenced
this pull request
Jan 3, 2023
* docs: update constructor doc comment of geometries See: mrdoob/three.js#25086 * docs: update doc comment of the constructor of BufferAttribute See: mrdoob/three.js#25046 the `normalized` was already optional in the typedef * feat: add TwoPassDoubleSide See: mrdoob/three.js#25165 also add doc comment of Side * feat: add `Mesh.getVertexPosition()` - add `Mesh.getVertexPosition()` - add doc comment of `SceneUtils.reduceVertices` See: mrdoob/three.js#25049 * feat: add `Object3D.getObjectsByProperty()` - add `Object3D.getObjectsByProperty()` - add doc comment of `Object3D.getObjectByProperty()` See: mrdoob/three.js#25006 * docs: add a doc comment of `PointLight.castShadow` See: mrdoob/three.js#25136 * feat (GLTFLoader): add loadNode hook See: mrdoob/three.js#25077 * feat (Nodes): New features and revisions - add three new nodes: `CacheNode`, `StackNode`, and `SpecularMIPLevelNode` - add `NodeCache` - add `getDefaultUV()` to `CubeTextureNode` and `TextureNode` - add `isGlobal()` to `Node` - add `cache` and `globalCache` to `NodeBuilder` - add missing `flowsData` to `NodeBuilder` - add `hasDependencies` to `TempNode` - add `maxMipLevel` and `cache` to `ShaderNodeBaseElements` - replace `maxMipLevel` -> `specularMIPLevel` of `ShaderNodeElements` - change constructor type and texture type of `MaxMipLevelNode` - add `SpecularMIPLevelNode` * feat (Nodes): add FogExp2 node Co-authored-by: Josh <37798644+joshuaellis@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Pull Request: #22141
Description
All other geometries that had blender defaults were changed to match those defaults. The changes are as follows (SphereGeometry included just for consistency):
SphereGeometry: 8 width, 6 height -> 32 width, 16 height
CircleGeometry: 8 radial -> 32 radial
RingGeometry: 8 radial -> 32 radial
CylinderGeometry: 8 radial -> 32 radial
ConeGeometry: 8 radial -> 32 radial
TorusGeometry: 8 radial, 6 tube -> 12 radial, 48 tube