Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SVGLoader: Add vertices along counterclockwise if bevel. #27121

Merged
merged 2 commits into from Nov 9, 2023
Merged

SVGLoader: Add vertices along counterclockwise if bevel. #27121

merged 2 commits into from Nov 9, 2023
+4 −4

Conversation

nieyuyao
Copy link
Contributor

@nieyuyao nieyuyao commented Nov 5, 2023 •
edited by Mugen87

Fixed #26784.

@nieyuyao nieyuyao marked this pull request as ready for review November 6, 2023 10:40
@Mugen87
Copy link
Collaborator

Mugen87 commented Nov 7, 2023

I have tested your PR today and it seems it does not fully fix #26784. One triangle is now rendered correctly but the second one is still reversed:

current:
image
expected:
image

@nieyuyao nieyuyao marked this pull request as draft November 8, 2023 03:23
@nieyuyao
Copy link
Contributor Author

nieyuyao commented Nov 8, 2023

In the previous fix, i ignored the issue when lineCap is square. I submitted the code again. @Mugen87

@nieyuyao nieyuyao marked this pull request as ready for review November 8, 2023 14:28
@Mugen87 Mugen87 changed the title fix: add vertices along counterclockwise if bevel SVGLoader: Add vertices along counterclockwise if bevel. Nov 9, 2023
@Mugen87
Copy link
Collaborator

Mugen87 commented Nov 9, 2023

BTW: The bug was also reproducible with the joins and caps asset from webgl_loader_svg. However, it wasn't noticed since the material is double sided. With this PR, the asset is rendered with front sided materials correctly, too!

@Mugen87 Mugen87 merged commit b5d1167 into mrdoob:dev Nov 9, 2023
19 checks passed
@Mugen87 Mugen87 added this to the r159 milestone Nov 9, 2023
@nieyuyao nieyuyao deleted the fix/svg-bevel-join-vertex branch November 10, 2023 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r159
Development

Successfully merging this pull request may close these issues.

SVGLoader pointsToStroke incorrect results when linejoin set to bevel
2 participants
@nieyuyao @Mugen87