chore: replace the cdn, unpkg -> jsdelivr #28006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`unpkg.com/` -> `cdn.jsdelivr.net/npm/` I checked all changed examples, editor, manuals are working properly Context: unpkg is not reliable, especially when we are using NodeMaterials since there are a lot of modules to load. See: mrdoob#28002 (comment) Note that I also replaced in `editor-settings.js` I excluded `editor/js/libs/ffmpeg.min.js` and `examples/jsm/libs/chevrotain.module.min.js` `webgl2_ubo_arrays.html` still imports es-module-shims, is this required?
|
Let me know if I still have something to change. |
|
Do you mind removing the build files from the PR?
No, the shim can be removed 👍 . |
ouch, thank you. I just removed. |
addressed @ b12dd2f |
Mugen87
approved these changes
Mar 26, 2024
0b5vr
added a commit
to pixiv/three-vrm
that referenced
this pull request
Mar 27, 2024
Also update README to recommend jsDelivr Following the Three.js side change. See: mrdoob/three.js#28006 es-module-shims for import map is also no longer used in Three.js examples. See: mrdoob/three.js#26836
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will resolve #28002
Description
I changed the CDN from unpkg to jsDelivr.
unpkg.com/->cdn.jsdelivr.net/npm/I checked all changed examples, editor, manuals are working properly.
Context
unpkg is not reliable, especially when we are using NodeMaterials since there are a lot of modules to load.
See: #28002 (comment)
Notes
editor-settings.jseditor/js/libs/ffmpeg.min.jsandexamples/jsm/libs/chevrotain.module.min.jswebgl2_ubo_arrays.htmlstill imports es-module-shims, is this required?