Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: replace the cdn, unpkg -> jsdelivr #28006

Merged
merged 2 commits into from
Mar 26, 2024
Merged

chore: replace the cdn, unpkg -> jsdelivr #28006

merged 2 commits into from
Mar 26, 2024

Commits on Mar 26, 2024

  1. chore: replace the cdn, unpkg -> jsdelivr 

    `unpkg.com/` -> `cdn.jsdelivr.net/npm/`

I checked all changed examples, editor, manuals are working properly

Context: unpkg is not reliable, especially when we are using NodeMaterials since there are a lot of modules to load.

See: mrdoob#28002 (comment)

Note that I also replaced in `editor-settings.js`

I excluded `editor/js/libs/ffmpeg.min.js` and `examples/jsm/libs/chevrotain.module.min.js`

`webgl2_ubo_arrays.html` still imports es-module-shims, is this required?
    @0b5vr
    0b5vr committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    460813b View commit details
    Browse the repository at this point in the history

  2. chore: remove es-module-shims from webgl2_ubo_arrays.html 

    See: mrdoob#28006 (comment)
    @0b5vr
    0b5vr committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    b12dd2f View commit details
    Browse the repository at this point in the history