New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebGPURenderer: Fix SampledTexture not correctly bound #28289
Conversation
All |
Sorry, I'm not familiar with the E2E tests so I have no idea what's going wrong. I try to disable E2E testing manually for the moment. |
@sunag Does this change seems ok with you? After 2 days of tests I can't reproduce my issue anymore when resizing the window on PostProcess setup. (I would suggest to remove the getter |
Exactly what I would suggest. This section, if I'm not mistaken, was supposed to load a Another thing that caught my attention. I think |
Make sense! Indeed |
Related issue: #28268
Description
When resizing a
RenderTarget
, for example using a PostProcess pipeline with aPassNode
, the resize will triggerthis.renderTarget.setSize()
which will dispatchdispose
destroying the associated textures in the backend and then lose the proper binding on the GPU side:This PR fix
SampledTexture
binding update. Related comment #28268 (comment)With this fix, the error seems to no longer appears.
This contribution is funded by Utsubo