-
-
Notifications
You must be signed in to change notification settings - Fork 35.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editor: Fixed sidebar glitches #28358
Conversation
editor/js/Config.js
Outdated
'en': 350, | ||
'fr': 355, | ||
'ja': 395, | ||
'zh': 335 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is yet more code that needs to be maintained.
I'm sure there's a solution for this issue that doesn't create more maintenance work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
css?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, i found a way to eliminate those numbers, by auto sniffing the possible max width among tabbed panels inside the sidebar
done :D |
Making the tabs horizontally scrollable may be a better solution. |
done. see #28467 |
The issues:
ja
, so on first-run, the property tabs will be wrapped:Currently sidebar's width is unrecoverable, so say Japanese users have to resize the sidebar every time the editor restarted (including refresh the page for purging texture input's cache :D)
Resizer can be dragged way too far to the right, so for languages
fr
andja
the property tabs will be wrapped:resizer.too.far.mp4
resizer.is.gone.mp4
This PR:
Preview: (open in incognito mode to mimic first-run) https://raw.githack.com/ycw/three.js/editor-sidebar-width-is-user-pref/editor/index.html