Editor: Fixed sidebar glitch via h scrollable #28467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ycw
force-pushed
the
editor-scrollable-tabsbar
branch
from
05d155b
to
e687a6a
Compare
mrdoob
reviewed
May 24, 2024
| @@ -1130,6 +1130,7 @@ class UITabbedPanel extends UIDiv { | |||
| if ( tab ) { | |||
|
|
|||
| tab.addClass( 'selected' ); | |||
| tab.dom.scrollIntoView( { inline: 'center', behavior: 'smooth' } ); | |||
There was a problem hiding this comment.
That's nice! I didn't know about this 🙏
There was a problem hiding this comment.
Note that there's an issue when using scrollIntoView in the editor, and its solved by using scrollTo instead, see #28485 🙏🏻 sorry for that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixed sidebar glitch(#28358) by using horizontal scrollable tabs in
UITabbedPanel, this approach was suggested by @mrdoob #28358 (comment):h.scrollable.tabsbar.mp4
Preview: https://raw.githack.com/ycw/three.js/editor-scrollable-tabsbar/editor/index.html