#9663: Fix radius bug in CylinderBufferGeometry #9672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -153,7 +153,7 @@ function CylinderBufferGeometry( radiusTop, radiusBottom, height, radialSegments | |||
|
|
|||
| // handle special case if radiusTop/radiusBottom is zero | |||
|
|
|||
| if ( ( radiusTop === 0 && y === 0 ) || ( radiusBottom === 0 && y === heightSegments ) ) { | |||
| if ( ( radiusTop < Number.EPSILON && y === 0 ) || ( radiusBottom < Number.EPSILON && y === heightSegments ) ) { | |||
There was a problem hiding this comment.
Do you need this special case? I'm not sure you do; just don't multiply by radius first?
|
@WestLangley Good point! What do you think about the last commit? No special cases any more... |
|
@Mugen87 Not tested, but something like: var u = x / radialSegments;
var theta = u * thetaLength + thetaStart;
var sinTheta = Math.sin( theta );
var cosTheta = Math.cos( theta );
// vertex
vertices.setXYZ( index, radius * sinTheta, - v * height + halfHeight, radius * cosTheta );
// normal
normal.set( sinTheta, tanTheta, cosTheta ).normalize(); // tanTheta should be renamed, IMO
normals.setXYZ( index, normal.x, normal.y, normal.z ); |
|
Would be something like |
|
Doesn't matter. It is just not the same |
|
Done! 😊 |
|
@WestLangley all good? |
|
OK. Thanks, @Mugen87. |
|
Yays! |
|
Thanks everyone, I really appreciate it! 😄 |
aardgoose
pushed a commit
to aardgoose/three.js
that referenced
this pull request
Oct 7, 2016
* mrdoob#9663: Fix radius bug in CylinderBufferGeometry * CylinderBufferGeometry: simplify normal generation * CylinderBufferGeometry: Cleanup * CylinderBufferGeometry: Rename tanTheta variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #9663.
The zero comparison does not work in some special cases with radius values very close to zero. Instead we now using a tolerance value (Number.EPSILON).