Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Converted every api call to Either #47

Merged
merged 1 commit into from
May 17, 2020
Merged

Converted every api call to Either #47

merged 1 commit into from
May 17, 2020

Conversation

mrf7
Copy link
Owner

@mrf7 mrf7 commented May 17, 2020

No description provided.

@todo
Copy link

todo bot commented May 17, 2020

handle the error case

DJApp/app/src/main/java/com/mfriend/djapp/reviewrequests/ReviewRequestsViewModel.kt

Lines 59 to 62 in 8fd98d1

// TODO handle the error case
reviewRequestRepo.addSongToPlaylist(trackToAdd, playlist)
nextSong()
}

This comment was generated by todo based on a TODO comment in 8fd98d1 in #47. cc @mrf7.

@mrf7 mrf7 merged commit 72a1a05 into master May 17, 2020
@todo todo bot mentioned this pull request May 17, 2020
Open
@mrf7 mrf7 deleted the feature/convert-to-either branch May 17, 2020 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mrf7