Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offload markdown parsing to marked and html-to-pdfmake #58

Merged
merged 1 commit into from
Jun 12, 2020

Conversation

andyrooger
Copy link
Contributor

I had a look at improving the MD to pdfmake code, but why do it yourself if someone else already has? :)

There's surprisingly few libraries to do the full conversion in one go, but going via HTML first seems to work well.

I've added the string \n1. first\n2. second\n 1. first inner\n 2. second inner\n3. third\n\n| col1 | col2 |\n|---|---|\n|val1|val2| to the end of the petstore example and got this

image

Fixes #53 and #49

@mrin9
Copy link
Owner

mrin9 commented Jun 6, 2020

great PR !!!,
I had been working on a library to create a marked parser to output an pdfMake syntax. Somehow I missed to spot the html-to-pdfMake library, I will most likely go with your approach now.

I am held up with some work now, but will review it as soon as I get some time on it

Thanks for the PR !!!

@andyrooger
Copy link
Contributor Author

Thanks :)

I would have volunteered properly when I raised this to avoid us duplicating effort, but I wasn't sure if I'd be able to find time.

@mrin9 mrin9 merged commit 3ef6fe7 into mrin9:master Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nested lists in description not supported
2 participants