Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blind to master PR -- With revisions #22

Closed
wants to merge 6 commits into from
Closed

Blind to master PR -- With revisions #22

wants to merge 6 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Aug 10, 2016

Try to satisfy grumpy travis.

@mrkkrp
Copy link
Owner

mrkkrp commented Aug 10, 2016

Please don't close/reopen if this fails.

@coveralls
Copy link

Coverage Status

Coverage decreased (-3.6%) to 81.765% when pulling 594d57a on robertLeeGDM:blind into 5d90757 on mrkkrp:master.

@ghost ghost closed this Aug 10, 2016
@ghost
Copy link
Author

ghost commented Aug 10, 2016

Damnit!!! I clicked wrong!

@ghost ghost reopened this Aug 10, 2016
@mrkkrp
Copy link
Owner

mrkkrp commented Aug 10, 2016

@robertLeeGDM, Can you please rebase so we have one commit with clear description?

mrkkrp
mrkkrp reviewed Aug 13, 2016
View reviewed changes
Codec/Archive/Zip.hs
@@ -188,6 +191,46 @@ data ZipState = ZipState
-- ^ Pending actions
}



Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Every function should have description. The Handle argument should have it as well.

@mrkkrp
Copy link
Owner

mrkkrp commented Nov 16, 2016 •
edited
Loading

What is status of this? Should I close due to the lack of activity?

@ghost
Copy link
Author

ghost commented Nov 16, 2016

Sorry about that. I've been too deep in the weeds of a Haskell based
medical application for demo at MEDICA in Germany to get back to this.
I have next week off of work so I can clean it up then.
Thanks for the reminder!
On Wed, 2016-11-16 at 10:05 -0800, Mark Karpov wrote:

What is the status of this? Should I close due to the lack of
activity?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@mrkkrp mrkkrp mentioned this pull request Jun 8, 2017
Closed
@ghost ghost mentioned this pull request Jan 25, 2018
Closed
@mrkkrp mrkkrp force-pushed the master branch 2 times, most recently from d971f23 to 1d2559e Compare February 5, 2018 16:05
@mrkkrp
Copy link
Owner

mrkkrp commented May 23, 2018

This PR doesn't seem to be active, closing.

@mrkkrp mrkkrp closed this May 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrkkrp @coveralls