Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set parameters #40

Open
JakubHazik opened this issue Apr 18, 2018 · 2 comments
Open

Set parameters #40

JakubHazik opened this issue Apr 18, 2018 · 2 comments
Assignees

Comments

@JakubHazik
Copy link

JakubHazik commented Apr 18, 2018

Is possible set parameters for example sigma distribution of lidar beams or resolution of a map?
I talk about mrpt_icp_slam_2d package

@Logrus Logrus self-assigned this Mar 19, 2019
@Logrus
Copy link
Member

Logrus commented Mar 19, 2019

I will improve parametrization of all nodes.

@jlblancoc
Copy link
Member

Great!
@Logrus : Just in case, take a look at the regression I inadvertidly introduced a few days ago trying to avoid pointers, here:
mrpt-ros-pkg/mrpt_navigation@76db0c7#diff-eafe347e79a69eca21d60da0a53ce9e7L79

It was fixed here: mrpt-ros-pkg/mrpt_navigation@75b539d

I can't remember if more nodes use the same approach of inheriting the Parameters struct (Node ==> Library), but it would be better split into two structs, as in my second commit above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

3 participants