Fixes for ESP8266 platform #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssues on ESP8266 code and made them compilable again. Bump version to 1.1.6, add documentation for ESP8266 port.
|
@kiwi64ajs Please have a look on fixed code, have you an clang-format file for source code formatting? |
|
Awesome - many thanks for doing that.
I took a look at it last night and tried to sort it out but gave up and went to bed…
I need to start using VSCode more for things like this as I couldn’t see the missing pre-processor directive.
Alex
… On 8/03/2021, at 6:19 AM, Björn Rennfanz ***@***.***> wrote:
@kiwi64ajs <https://github.com/kiwi64ajs> Please have a look on fixed code.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#20 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB5Y53JWYS4NZEA27UR4ULDTCOYRDANCNFSM4YYB2QBA>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reformated all source files using Visual Studio, fixed merge/rebase issues on ESP8266 platform code and made them compilable again. Bump version to 1.1.6, add documentation for ESP8266 port.