Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Heap buffer overflow introduced in #3553 #3572

Closed
Asmod4n opened this issue Apr 1, 2017 · 0 comments
Closed

Heap buffer overflow introduced in #3553 #3572

Asmod4n opened this issue Apr 1, 2017 · 0 comments

Comments

@Asmod4n
Copy link
Contributor

Asmod4n commented Apr 1, 2017

https://github.com/mruby/mruby/pull/3553/files#diff-d13030dbdc98ec484fa8f0e9cbc31443R218 is accessing one element too much of the array, tests still pass when <= is changed to < in for (j = i; j <= a->len - len; ++j) { block but dunno if it still works as expected.

These kind of bugs can be found quite good with

  conf.cc.flags << '-fsanitize=address'
  conf.linker.flags << '-fsanitize=address'

added to build_config.rb
@matz matz closed this as completed in 5d00e85 Apr 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Asmod4n