Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SerializerBuilder<TObject>.GetTargetMembers() stricter (fix #28) (+ trivial fixes) #32

Merged
merged 3 commits into from
Jun 28, 2014

Conversation

takeshik
Copy link
Contributor

Overview

Re-submit of #30.

  • Add a special targetting for members which isn't able to set but is addable collection or dictionary.
  • There is a bug in SerializerDebugging.ResetDependentAssemblies() method: it doesn't writes out newline before the EOF. This makes invalid paths (perhaps) next test run. This PR fixes it.
  • Components in .nuget/ of this repo (or branch) is old, it fails to restore packages. This PR renew them.

Notes

  • All unit-tests are passed in my environment.
  • I'm worried that the name of new private method, CheckTargetEligibility, might be not good. Please rename it if you need.

If there are any trouble, please tell me.

Takeshi KIRIYA added 3 commits June 23, 2014 21:15
Remove non-accessible members from the target:
  * properties which has no public setter, or
  * fields which is initonly,
  * moreover, it is not a addable collection nor dictionary.
@yfakariya yfakariya merged commit d641a6e into msgpack:0.5 Jun 28, 2014
@yfakariya
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants