Skip to content

Fix wrong skipValue position count #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 28, 2015
Merged

Fix wrong skipValue position count #185

merged 1 commit into from
Jan 28, 2015

Conversation

miniway
Copy link
Contributor

@miniway miniway commented Jan 28, 2015

readNextLength16 and readNextLength32 already advances buffer position so skipValue should not advance position on Array and MapType.

@xerial
Copy link
Member

xerial commented Jan 28, 2015

Good catch! Thanks.

xerial added a commit that referenced this pull request Jan 28, 2015
@xerial
Merge pull request #185 from miniway/v07-develop
1f057e7 
Fix wrong skipValue position count
@xerial xerial merged commit 1f057e7 into msgpack:v07-develop Jan 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@miniway @xerial