Skip to content

Conversation

sergeyzenchenko
Copy link
Collaborator

In some cases Decoder/Encoder need to be used directly without wrapper functions. For example in our project we have custom format that consist of
binary with:

  • number
  • number
  • array
  • number
  • binary

and this structure can't be parsed or formed using regular functions, but it can be easily done by using Decoder/Encoder directly.

@sergeyzenchenko
Copy link
Collaborator Author

@gfx what do you think about it?

@codecov-io
Copy link

codecov-io commented May 30, 2019

Codecov Report

Merging #45 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #45      +/-   ##
==========================================
+ Coverage   91.46%   91.48%   +0.02%     
==========================================
  Files          14       14              
  Lines         808      810       +2     
  Branches      170      170              
==========================================
+ Hits          739      741       +2     
  Misses         49       49              
  Partials       20       20
Impacted Files Coverage Δ
src/index.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e3f706...dd3ae57. Read the comment docs.

@sergeyzenchenko sergeyzenchenko requested a review from gfx May 30, 2019 12:46
@gfx
Copy link
Member

gfx commented May 30, 2019

The reason why they are not exported is just their interfaces are not stable yet and there are no use cases suggested, but if you need them, it's time to export them.

LGTM

@sergeyzenchenko
Copy link
Collaborator Author

thanks!

@sergeyzenchenko sergeyzenchenko merged commit 580e798 into master May 30, 2019
@sergeyzenchenko sergeyzenchenko deleted the export_decoder_encoder branch May 30, 2019 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants