simplify type of decode()'s first arg; ArrayLike<number> includes Uint8Array, anyway #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sergeyzenchenko can you review it please? |
gfx
changed the title
Codecov Report
@@ Coverage Diff @@
## master #51 +/- ##
==========================================
- Coverage 96.57% 96.57% -0.01%
==========================================
Files 15 15
Lines 906 905 -1
Branches 183 183
==========================================
- Hits 875 874 -1
Misses 31 31
Continue to review full report at Codecov.
|
sergeyzenchenko
approved these changes
May 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In readme,
decodeStream(stream: AsyncIterable<Uint8Array | ArrayLike<number>> | ReadableStream<Uint8Array | ArrayLike<number>>, options?: DecodeAsyncOptions): AsyncIterable<unknown>is too complex to read.Because
Uint8ArrayincludesArrayLike<number>,Uint8Array | ArrayLike<number>can be simplified toArrayLike<number>.