added distinguish_tuple argument to Packer #100
Conversation
This will make precise python types serialization possible.
|
Detailed motivation here: |
|
Could you pack object which type is like following? class MyList(list):
__slots__ = ()I think I can't support precise packing Python types without breaking backward compatibility... |
|
Hm... indeed, looks like in this case such class with be serialized as list and class information will be lost. The solution I see is instead of "distinguish_tuple" argument it is better to add argument "precise_mode" and if that one is set, it will make an accurate type checks: type(x) is list instead of: isinstance(x, list) That should allow to do accurate serialization and keep the backward compatibility. What do you think about that? |
|
msgpack-python API is come from simplejson. http://simplejson.readthedocs.org/en/latest/#encoders-and-decoders
I'll follow it. |
|
If you want to serialize Python types completely, use pickle. |
|
Pickle can't be used in my case, becase if is not safe when data comes from untrusted source. |
When precise_mode flag is set, serialization will be as precise as possible - type checks will be exact (type(..) is ... instead of isinstance(..., ...) and tuple will be treated as undefined type. This mode is to make accurate object serialization possible.
| :param bool precise_mode: | ||
| If set to true, types will be checked to be exact. Derived classes | ||
| from serializeable types will not be serialized and will be | ||
| treated as unsupported type and forwarded to default. |
There was a problem hiding this comment.
I don't like precise_mode name since it doesn't mention about types.
What about strict_types?
This will make precise python types serialization possible.