Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

neoantigenEditing subworkflow #63

Merged
merged 8 commits into from
Mar 29, 2024
Merged

neoantigenEditing subworkflow #63

merged 8 commits into from
Mar 29, 2024

Conversation

johnoooh
Copy link
Collaborator

@johnoooh johnoooh commented Mar 22, 2024

neoantigenEditing from Luksza et al

PR checklist
This comment contains a description of changes (with reason).

  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure code lints (using prettier)

Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:

  • nf-test test --profile=docker --tag
  • nf-test test --profile=singularity --tag
  • nf-test test --profile=conda --tag (not applicable; conda nf-test is disabled)

subworkflows/msk/neoantigen_editing/main.nf Outdated Show resolved Hide resolved
subworkflows/msk/neoantigen_editing/meta.yml Outdated Show resolved Hide resolved
@nikhil nikhil merged commit df51966 into neoantigen Mar 29, 2024
11 of 13 checks passed
@nikhil nikhil deleted the neoantigenEditing branch March 29, 2024 15:37
@nikhil
Copy link
Collaborator

nikhil commented Mar 29, 2024

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants