-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(MITO) Trips.csv to MATSim Plans.xml #54
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dear Raoul,
From a matsim perspective I would rather keep the "passenger" trip in the population. We very much prefer to "teleport" such modes rather than not having them at all. Not having them at all always means that one has to retrofit statistics, which is error prone, and one has to start over when one needs such modes for some other study, which is always a lot of work. Could you please consider that? Otherwise, could we please bring it up at the next skype meeting?
Thanks ...
On 7. Mar 2019, at 19:46, Raoul <notifications@github.com<mailto:notifications@github.com>> wrote:
Added conversion class to convert trip.csv files into MATSim population.xml files.
…________________________________
You can view, comment on, or merge this pull request online at:
#54
Commit Summary
* Update TripCSVToMATSimPlan.java
* Update TripCSVToMATSimPlan.java
* Update .gitignore
* Filter "autoPassenger" from MATSim population
File Changes
* M .gitignore<https://github.com/msmobility/mito/pull/54/files#diff-0> (1)
* M src/main/java/de/tum/bgu/msm/modules/trafficAssignment/TripCSVToMATSimPlan.java<https://github.com/msmobility/mito/pull/54/files#diff-1> (173)
Patch Links:
* https://github.com/msmobility/mito/pull/54.patch
* https://github.com/msmobility/mito/pull/54.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub<#54>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AIXvsW9ZLV0lfT7lMHeUzfeTL_nk4cfjks5vUV5wgaJpZM4bj3QM>.
======================================================
Clone github.com/matsim-org/matsim-example-project<http://github.com/matsim-org/matsim-example-project> to get started.
Look at github.com/matsim-org/matsim-code-examples<http://github.com/matsim-org/matsim-code-examples> for code examples.
Also see matsim.org/downloads<http://matsim.org/downloads> | matsim.org/docs/tutorials<http://matsim.org/docs/tutorials> | matsim.org/open-scenario-data<http://matsim.org/open-scenario-data> | matsim.org/faq<http://matsim.org/faq> .
---
www.vsp.tu-berlin.de<http://www.vsp.tu-berlin.de>
+49 30 314 23308 (phone) +49 30 314 26269 (fax)
TU Berlin Sekr. SG 12, Salzufer 17-19, 10587 Berlin
|
Dear Prof. Nagel, thank you for the input, I've changed the conversion class accordingly to include autoPassenger (as car_passenger) instead of removing them (see f62d8c5) and will adjust my simulation accordingly! Best, Raoul |
Great! For consistency I agree with that. |
Thanks ...
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added conversion class to convert trip.csv files into MATSim population.xml files.