Skip to content

Conversation

lwnmengjing
Copy link
Member

Description

Checklist

  • the pull request title describes what this PR does (not a vague title like Update index.md)
  • the pull request targets the default branch of the repository (main)
  • no unintentional fmt.Print left behind after debugging
  • did I name variables, methods and classes according to the naming rules? (https://go.dev/doc/effective_go#names)
  • caught exceptions or throw them to the upper level for processing, not ignored (https://go.dev/doc/effective_go#errors)
  • did I explain all possible solutions and why I chose the one I did?
  • added any comments to make new functions clearer
  • tests are added for the changes I made (if any source code was modified)
  • documentation added or updated
  • I have run the project locally and verified that there are no errors
  • instructions for how reviewers can test the code locally
  • screenshot of the feature/bug fix (if applicable)

@lwnmengjing lwnmengjing requested review from Copilot and mss-boot and removed request for Copilot July 21, 2025 02:41
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates binding methods and error handling in the API response package to use more consistent and modern Go patterns. The changes improve consistency in binding method usage and modernize error type checking.

  • Replace BindQuery with ShouldBindWith for consistency across binding methods
  • Update error type assertion to use errors.As instead of type assertion for better error handling

@lwnmengjing lwnmengjing merged commit f857863 into main Jul 21, 2025
4 checks passed
@lwnmengjing lwnmengjing deleted the fix/api branch July 21, 2025 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants