This repository was archived by the owner on Oct 1, 2024. It is now read-only.
All geometry objects implement JsonSerializable #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PointCollection is now abstract since its children should implement jsonSerialize
1 similar comment
phaza
added a commit
that referenced
this pull request
May 8, 2015
All geometry objects implement JsonSerializable
|
Holy batman, very nice! |
|
Thanks, hoped you'd like it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once I have fetched the objects from PostGIS to laravel I want to pass them off to fractal which creates my json api.
That's why I thought the geometry objects should implement JsonSerializable.
I've required jmikola/geojson which is a PHP implementation for GeoJSON. All objects should now be returned in a GeoJSON Spec valid json.