Liquidator upgrade for ALCX #196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superduck35
approved these changes
Jul 15, 2021
There was a problem hiding this comment.
You are doing a lot of good work with the tasks etc.
Only thing I am concerned about here is the lack of liquidity in the ALCX/eth pair (see screenshot)
ALCX will be pulled weekly and is likely to be of a decent amount.. something to be aware of
Potential solutions (if required):
- Use the Sushiswap pair (same as Uniswap v2 interface) for ALCX->ETH
- liquidate on a more frequent basis (every 1-3 days depending on value accruing)
- Provide liquidity to the ALCX/ETH pair ourselves (20k or so)
| "test:file:long": "LONG_TESTS=true yarn hardhat test", | ||
| "prepublishOnly": "yarn run compile" | ||
| "copy-types": "cp -R types/generated dist/types", | ||
| "prepublishOnly": "yarn run compile && yarn run copy-types" |
There was a problem hiding this comment.
Super minor thing but you dont need the run with yarn
There was a problem hiding this comment.
I'll make is consistent with the other scripts and remove the runs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rewardstask upgraded to report ALCXprepublishOnlyscript to copy contract type definitions to/dist/types/generated