Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java reference implementation #6

Closed
gitblit opened this issue Nov 21, 2013 · 7 comments
Closed

Java reference implementation #6

gitblit opened this issue Nov 21, 2013 · 7 comments

Comments

@gitblit
Copy link
Contributor

gitblit commented Nov 21, 2013

I have another proposal for you: share your Java reference implementation.

It seems silly for both of us to code up 2 implementations of the same thing for the same language. I'm assuming you have a class that takes a commit message and a StoredConfig instance and works it's magic.

@mstrap
Copy link
Owner

mstrap commented Nov 21, 2013

That definitely makes sense. It requires some refactorings to get rid of SmartGit's infrastructure usage, though. I think you may expect my commit during the next week.

@gitblit
Copy link
Contributor Author

gitblit commented Nov 21, 2013

Sweet. That'll be a help. BTW, if SmartGit fails to parse .gitbugtraq, the UI remains in a disabled state for almost everything.

@gitblit
Copy link
Contributor Author

gitblit commented Nov 21, 2013

It also appears as though SmartGit will only process 1 bugtraq definition. I think it needs to support as many as are defined. For example, using JIRA and Gerrit together.

I actually want to define 3, for my Gitblit repository: issue (GoogleCode), pull request (GitHub), change-id (Gitblit/Gerrit). I know that Wikimedia - which runs Gerrit & Gitblit - would also want support for at least 2.

@mstrap
Copy link
Owner

mstrap commented Nov 22, 2013

That's true: currently SmartGit will stop processing bugtraq configurations for one message, once it has found a matching configuration. This simplification helps to avoid possibly overlapping links from different configurations. Anyway, I see that the main use case is to exactly support multiple links in one message, so I'll fix that in SmartGit.

@gitblit
Copy link
Contributor Author

gitblit commented Nov 22, 2013

Super! I think that will make adopters happy.

mstrap added a commit that referenced this issue Nov 23, 2013
@mstrap
Copy link
Owner

mstrap commented Nov 23, 2013

The reference implementation now also processes multiple configurations for one commit message.

@gitblit
Copy link
Contributor Author

gitblit commented Nov 25, 2013

Cool. I've cloned and I'll integrate later this week - might be over the weekend due to the Thanksgiving holiday.

@mstrap mstrap closed this as completed Dec 23, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants