-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Java reference implementation #6
Comments
That definitely makes sense. It requires some refactorings to get rid of SmartGit's infrastructure usage, though. I think you may expect my commit during the next week. |
Sweet. That'll be a help. BTW, if SmartGit fails to parse .gitbugtraq, the UI remains in a disabled state for almost everything. |
It also appears as though SmartGit will only process 1 bugtraq definition. I think it needs to support as many as are defined. For example, using JIRA and Gerrit together. I actually want to define 3, for my Gitblit repository: issue (GoogleCode), pull request (GitHub), change-id (Gitblit/Gerrit). I know that Wikimedia - which runs Gerrit & Gitblit - would also want support for at least 2. |
That's true: currently SmartGit will stop processing bugtraq configurations for one message, once it has found a matching configuration. This simplification helps to avoid possibly overlapping links from different configurations. Anyway, I see that the main use case is to exactly support multiple links in one message, so I'll fix that in SmartGit. |
Super! I think that will make adopters happy. |
The reference implementation now also processes multiple configurations for one commit message. |
Cool. I've cloned and I'll integrate later this week - might be over the weekend due to the Thanksgiving holiday. |
I have another proposal for you: share your Java reference implementation.
It seems silly for both of us to code up 2 implementations of the same thing for the same language. I'm assuming you have a class that takes a commit message and a StoredConfig instance and works it's magic.
The text was updated successfully, but these errors were encountered: