-
-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggests similar request handlers upon unhandled requests #560
Conversation
ffb012a
to
319c4f6
Compare
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 9d0addc:
|
8abbc06
to
c047c45
Compare
c047c45
to
f16261f
Compare
1ec77be
to
76551dd
Compare
Although |
76551dd
to
acf426e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a beauty @kettanaito !
I left a couple of subjective notes to make it a bit more readable.
test/msw-api/setup-worker/start/on-unhandled-request/suggestions.test.ts
Outdated
Show resolved
Hide resolved
test/msw-api/setup-worker/start/on-unhandled-request/suggestions.test.ts
Show resolved
Hide resolved
test/msw-api/setup-worker/start/on-unhandled-request/warn.mocks.ts
Outdated
Show resolved
Hide resolved
152a80b
to
21e03ab
Compare
@timdeschryver has made a great suggestion to include multiple handlers in the suggestions list. The first similar handler may not be the one a developer would be looking for. Including a list of up to 3-5 items of the suggestions with the same matching indices would be quite sensible. We can use |
2b1d55c
to
da41bfe
Compare
da41bfe
to
9d0addc
Compare
GitHub
Changes
Roadmap