Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prefix=/mingw64 missing in openssl.pc file #20763

Closed
3 of 7 tasks
newhoggy opened this issue Apr 29, 2024 · 3 comments · Fixed by #20769
Closed
3 of 7 tasks

prefix=/mingw64 missing in openssl.pc file #20763

newhoggy opened this issue Apr 29, 2024 · 3 comments · Fixed by #20769
Labels
bug reported-upstream Issues reported or fixed in upstream repository

Comments

@newhoggy
Copy link

newhoggy commented Apr 29, 2024

Description / Steps to reproduce the issue

Reproduction:

# pacman -Sw mingw-w64-x86_64-openssl
# tar xvf /var/cache/pacman/pkg/mingw-w64-x86_64-openssl-3.3.0-1-any.pkg.tar.zst

The above pc file does not use prefix.

Expected behavior

# cat mingw64/lib/pkgconfig/openssl.pc
libdir=/mingw64/lib
includedir=/mingw64/include

Name: OpenSSL
Description: Secure Sockets Layer and cryptography libraries and tools
Version: 3.3.0
Requires: libssl libcrypto

Actual behavior

# cat mingw64/lib/pkgconfig/openssl.pc
libdir=/mingw64/lib
includedir=/mingw64/include

Name: OpenSSL
Description: Secure Sockets Layer and cryptography libraries and tools
Version: 3.3.0
Requires: libssl libcrypto

Example good case for another library

# pacman -Sw mingw-w64-x86_64-gmp
# tar xvf /var/cache/pacman/pkg/mingw-w64-x86_64-gmp-6.3.0-2-any.pkg.tar.zst
# cat mingw64/lib/pkgconfig/gmp.pc
prefix=/mingw64
exec_prefix=${prefix}
includedir=${prefix}/include
libdir=${exec_prefix}/lib

Name: GNU MP
Description: GNU Multiple Precision Arithmetic Library
URL: https://gmplib.org
Version: 6.3.0
Cflags: -I${includedir}
Cflags.private: -DGMP_STATICLIB
Libs: -L${libdir} -lgmp

Because prefix= and ${prefix} are not used in the openssl case, this breaks openssl in Github Actions.

Verification

Windows Version

MINGW64_NT-10.0-20348 fv-az1111-280 3.4.10.x86_64 2024-04-08 18:11 UTC x86_64 Msys

MINGW environments affected

  • MINGW64
  • MINGW32
  • UCRT64
  • CLANG64
  • CLANG32
  • CLANGARM64

Are you willing to submit a PR?

No response

@newhoggy
Copy link
Author

Work around:

wget https://repo.msys2.org/mingw/mingw64/mingw-w64-x86_64-openssl-3.2.1-1-any.pkg.tar.zst
pacman -Uy mingw-w64-x86_64-openssl-3.2.1-1-any.pkg.tar.zst

@lazka
Copy link
Member

lazka commented Apr 29, 2024

Confirmed. Thanks.

Note that prefix isn't strictly needed, since our pkg-config computes it automatically. But if it's missing the automatic fixing of the other variables starting with /mingw64 instead of "${prefix}" fails.

@lazka
Copy link
Member

lazka commented Apr 29, 2024

Filed upstream: openssl/openssl#24298

lazka added a commit to lazka/MINGW-packages that referenced this issue Apr 29, 2024
@Biswa96 Biswa96 added the reported-upstream Issues reported or fixed in upstream repository label May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug reported-upstream Issues reported or fixed in upstream repository
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants