Clang: Backport fixes for Objective-C on mingw #19767
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request:
Backports the following fixes for clang:
which support compiling Objective-C code on mingw using Clang.
Since these fixes are specific to mingw, I hope it's appropriate to backport them to this repository before they land in the next clang release.
Additionally, around the time this PR was being created, the llvm repository switched from a state where the first 14 characters of the commit hash were sufficient to uniquely identify a commit (e.g.
f55e5434dce360
) to a state where 15 characters were required (e.g.f55e5434dce360b
).For example, I was able to have llvm/llvm-project@10b78cc8cea65e7e77d227af4027963f39402724 return the following two fragments (note the difference in the
index
line).vs.
This caused the builds to fail intermittently, depending on which (cached) version of the patch was returned by GitHub (presumably because different front-end servers were being hit, with a different cached version).
As a result, I believe using
https://github.com/llvm/llvm-project/commit/{commit-id}.patch
together with sha256 checksums is unstable, as the representation of the patch can change, and I've added the commits themselves to the mingw-w64-clang directory.