Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Presolve rules and documentation template #7

Merged
merged 8 commits into from
Dec 23, 2020
Merged

Conversation

mtanneau
Copy link
Owner

WIP. Early feedback is welcome.

Once this is satisfactory, I'll move to the other rules.

src/lp/fixed_variable.jl Outdated Show resolved Hide resolved
src/options.jl Show resolved Hide resolved
src/lp/fixed_variable.jl Outdated Show resolved Hide resolved
docs/make.jl Outdated Show resolved Hide resolved
@mtanneau mtanneau marked this pull request as ready for review December 15, 2020 20:29
@mtanneau mtanneau changed the title [RFC] Presolve rules and documentation template Presolve rules and documentation template Dec 15, 2020
Copy link
Collaborator

@joehuchette joehuchette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good to me, just some minor comments on the comments.

src/lp/fixed_variable.jl Outdated Show resolved Hide resolved
src/lp/fixed_variable.jl Outdated Show resolved Hide resolved
src/lp/fixed_variable.jl Outdated Show resolved Hide resolved
src/lp/fixed_variable.jl Show resolved Hide resolved
@mtanneau
Copy link
Owner Author

Last call for objections, otherwise I'll merge this tomorrow morning.

@mtanneau mtanneau changed the title Presolve rules and documentation template [DNMY] Presolve rules and documentation template Dec 17, 2020
@mtanneau
Copy link
Owner Author

I just realized the infeasibility check can be tightened for binary variables (the variable should be fixed to either 0 or 1, not just an integer).

I'll add this before merging.

@mtanneau mtanneau mentioned this pull request Dec 17, 2020
src/lp/fixed_variable.jl Outdated Show resolved Hide resolved
@mtanneau
Copy link
Owner Author

I think I'm 99% satisfied now 😅
I made the docs for FixSingleVariable as extensive as possible, so it can be used as template for other rules.

The last 1% covers whether parts of that doc should rather be tied to the FixedVariable reduction, but I'll leave that for future work.

Copy link
Collaborator

@joehuchette joehuchette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

src/lp/fixed_variable.jl Outdated Show resolved Hide resolved
src/lp/fixed_variable.jl Outdated Show resolved Hide resolved
src/lp/fixed_variable.jl Outdated Show resolved Hide resolved
src/lp/fixed_variable.jl Show resolved Hide resolved
src/lp/fixed_variable.jl Show resolved Hide resolved
@mtanneau mtanneau changed the title [DNMY] Presolve rules and documentation template Presolve rules and documentation template Dec 22, 2020
@mtanneau mtanneau merged commit 68530b4 into master Dec 23, 2020
@mtanneau mtanneau deleted the mt-PresolveRules branch December 23, 2020 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants