-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Presolve rules and documentation template #7
Conversation
33fffae
to
8a3d440
Compare
25d2466
to
a322bc3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good to me, just some minor comments on the comments.
Last call for objections, otherwise I'll merge this tomorrow morning. |
I just realized the infeasibility check can be tightened for binary variables (the variable should be fixed to either I'll add this before merging. |
4ac016d
to
2b73ca3
Compare
I think I'm 99% satisfied now 😅 The last 1% covers whether parts of that doc should rather be tied to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
WIP. Early feedback is welcome.
Once this is satisfactory, I'll move to the other rules.