ensure_integer_bounds

[BochuanBob]

Added a function to ensure the bounds of integer variables to be integral.

[mtanneau]

How come varTypes only has 3 elements and we're not getting an error when loading the problem?

[joehuchette]

This is indeed odd, would have thought this would catch it:

MathOptPresolve.jl/src/problem_data.jl

Lines 122 to 124 in 5a64d16

	if var_types !== nothing
	nvar == length(var_types) || error("")
	end

[joehuchette]

Did we figure out why this is happening?

[mtanneau]

IDK

[BochuanBob]

In the first version, the test function wasn't called in runtests.jl.

[joehuchette]

This is indeed odd, would have thought this would catch it:

MathOptPresolve.jl/src/problem_data.jl

Lines 122 to 124 in 5a64d16

	if var_types !== nothing
	nvar == length(var_types) || error("")
	end

[mtanneau]

As far as naming goes, I would prefer something in the likes of "Round integer bounds", following, e.g., the convention in this paper

[joehuchette]

LGTM

[joehuchette]

@BochuanBob there are merge conflicts now that #7 landed. Thankfully, looks like they should be easy to fix. Can you fixup the PR? We can switch to the apply! interface in a separate PR, I think.

[codecov-io]

Codecov Report

Merging #8 (e87677d) into master (68530b4) will increase coverage by 1.39%.
The diff coverage is 81.81%.

@@            Coverage Diff             @@
##           master       #8      +/-   ##
==========================================
+ Coverage   45.17%   46.56%   +1.39%     
==========================================
  Files          12       13       +1     
  Lines         870      902      +32     
==========================================
+ Hits          393      420      +27     
- Misses        477      482       +5     

Impacted Files	Coverage Δ
src/presolve.jl	45.28% <57.14%> (+0.66%)	⬆️
src/mip/round_integer_bounds.jl	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68530b4...e87677d. Read the comment docs.

[joehuchette]

Thanks, @BochuanBob, nice work!