* uuid command handling in agent not as expected #419

EMPreethi · 2024-03-06T10:16:37Z

I want to change UUID in agent by sending * uuid command from the adapter as a part of SHDR stream.
PreserveUUID is set to false.

I observed in REST output that UUID is changing, but none of the data items for the device is not getting recognized as below

024-03-06T09:30:53.442189Z (0x00007fccfd8b9b38) [trace] Connector::reader->Connector::parseSocketBuffer->Connector::processLine->ShdrAdapter::processData->DataItemMapper.ShdrTokenMapper.operator->DataItemMapper.ShdrTokenMapper.mapTokensToDataItem: Could not find data item: y1_abs 
2024-03-06T09:30:53.442200Z (0x00007fccfd8b9b38) [trace] Connector::reader->Connector::parseSocketBuffer->Connector::processLine->ShdrAdapter::processData->DataItemMapper.ShdrTokenMapper.operator->DataItemMapper.ShdrTokenMapper.mapTokensToDataItem: Could not find data item: 0.000000 
2024-03-06T09:30:53.442211Z (0x00007fccfd8b9b38) [trace] Connector::reader->Connector::parseSocketBuffer->Connector::processLine->ShdrAdapter::processData->DataItemMapper.ShdrTokenMapper.operator->DataItemMapper.ShdrTokenMapper.mapTokensToDataItem: Could not find data item: y1_axis_interlock

I also observed that UUID is changed for first * uuid command. Any repeated command with different UUID did not reflect in REST output.
Agent configuration as below

Devices = devices.xml
 ServerIP = 0.0.0.0
 Port = 5000
 AllowPut = false
 AllowPutFrom = localhost
 ReconnectInterval = 1000
 WorkerThreads = 2
 BufferSize = 17
 MaxAssets = 8096
 IgnoreTimestamps = true
 SchemaVersion = 2.0
 ShdrVersion = 2.0 # Set Default on all Adapters
 JsonVerson = 2.0
 SuppressIPAddress = true
 MonitorConfigFiles = true
 ConversionRequired = false
 UpcaseDataItemValue = true
 EnableSourceDeviceModels = false
 VersionDeviceXml = false
 Pretty = true
 Adapters {
    Saw {
      RealTime = false
      Protocol = shdr
      Host = 192.168.88.105
      Port = 9800
      PreserveUUID = false
   }
}

I expected to change UUID based on the machine connected to. Adapter streams the uuid command whenever there is change in machine and UUID of that machine is reflected in REST output of agent.

Is this a issue or expected behaviour?

Thanks

The text was updated successfully, but these errors were encountered:

wsobel · 2024-03-06T10:33:31Z

Can you send me the updated device XML file. It should have been rewritten. Thanks W

EMPreethi · 2024-03-06T11:03:46Z

I observed that Device XML file is not rewritten instead i saw changes only in REST output.

wsobel · 2024-03-06T13:26:35Z

Set VersionDeviceXml = true. That will update the device xml.

EMPreethi · 2024-03-07T04:56:43Z

Set VersionDeviceXml = true. That will update the device xml.

if VersionDeviceXml = true, I see UUID is overwritten in device XML file along with that i am sending SHDR data for all data items but status is shown as UNAVAILABLE.

When I refer to agent logs, looks like it is not able to identify data items but it is already defined in XML file.

device XML :

<?xml version="1.0" encoding="UTF-8"?> 
<?xml-stylesheet type="text/xsl" href="/styles/styles.xsl"?> 
<MTConnectDevices xmlns:m="urn:mtconnect.org:MTConnectDevices:2.0" xmlns="urn:mtconnect.org:MTConnectDevices:2.0" xmlns:xsi="
[http://www.w3.org/2001/XMLSchema-instance"](http://www.w3.org/2001/XMLSchema-instance%22)
xsi:schemaLocation="urn:mtconnect.org:MTConnectDevices:2.0 /schemas/MTConnectDevices_2.0.xsd"> 
<Header creationTime="2024-03-07T04:30:27Z" sender="e2c573fd5e38" instanceId="0" version="2.3.0.2" deviceModelChangeTime="2024-03-07T04:30:26.367824Z" assetBufferSize="0" assetCount="0" bufferSize="0"/> 
<Devices> 
<Device id="saw" name="Saw" uuid="smartAdapter_9845"> 
<Description manufacturer="omron">SmartSaw</Description> 
<Configuration> 
<CoordinateSystems> 
<CoordinateSystem id="world_coordinates" type="WORLD"> 
<Transformation>

Why agent is not able to identify SHDR data items when UUID changes ?

wsobel · 2024-03-07T05:08:20Z

Please attach or upload the Device xml. I want to see if the original ids are being serialized.

wsobel · 2024-03-07T05:10:09Z

Can you also attach or paste the shdr from the adapter. I want to see or check what's happening in the two.

EMPreethi · 2024-03-07T05:25:04Z

Attached a devices XML file :
devices.txt

adapter SHDR :
adapter_test.txt

Thanks

wsobel · 2024-03-11T03:03:45Z

I'll test this, not sure what is going wrong.

EMPreethi · 2024-03-11T07:04:21Z

Few of the observation I found:

Looks like after handling UUID command, agent does not updates to new UUID value even though it is changing in REST output.
Default UUID defined in XML File : smart_9845
command sent is * uuid : smart_9845_new

2024-03-11T06:53:14.697026Z (0x00007f047f4ebb38) [error] Connector::reader->Connector::parseSocketBuffer->Connector::processLine->ShdrAdapter::processData->ShdrAdapter::protocolCommand: _1a67104bd6:Received protocol command 'description' for device 'smart_9845', but the device could not be found 
2024-03-11T06:53:14.697043Z (0x00007f047f4ebb38) [debug] Connector::reader->Connector::parseSocketBuffer->Connector::processLine->ShdrAdapter::processData->ShdrAdapter::protocolCommand: Processing command: manufacturer: omron 
2024-03-11T06:53:14.697051Z (0x00007f047f4ebb38) [warning] Connector::reader->Connector::parseSocketBuffer->Connector::processLine->ShdrAdapter::processData->ShdrAdapter::protocolCommand: _1a67104bd6: Cannot find device for name smart_9845 
2024-03-11T06:53:14.697059Z (0x00007f047f4ebb38) [error] Connector::reader->Connector::parseSocketBuffer->Connector::processLine->ShdrAdapter::processData->ShdrAdapter::protocolCommand: _1a67104bd6:Received protocol command 'manufacturer' for device 'smart_9845', but the device could not be found

2.Adding Device configuration within Adapter block results in agent identifying every data item and handling command properly.

Adapters {
    Saw {
      Device = Saw
      RealTime = false
      Protocol = shdr
      Host = 192.168.88.105
      Port = 9800
      PreserveUUID = false
   }
}

If above Device config is not added, then streaming * device: Saw command from Adapter will also results in agent identifying every data items.

Thank you

wsobel · 2024-03-11T10:00:32Z

I'll check in the protocol comment for * uuid. I think I have enough to reproduce the issue.

Thanks

W

EMPreethi · 2024-03-26T05:17:53Z

@wsobel
When preserveUUID = true and a new UUID is sent from Adapter , I expected that Agent ignore the new UUID and should handle the SHDR data as normal

Based on my observation, it seems that the Agent is not handling the SHDR data properly when a new UUID is sent.

024-03-06T09:30:53.442189Z (0x00007fccfd8b9b38) [trace] Connector::reader->Connector::parseSocketBuffer->Connector::processLine->ShdrAdapter::processData->DataItemMapper.ShdrTokenMapper.operator->DataItemMapper.ShdrTokenMapper.mapTokensToDataItem: Could not find data item: y1_abs 
2024-03-06T09:30:53.442200Z (0x00007fccfd8b9b38) [trace] Connector::reader->Connector::parseSocketBuffer->Connector::processLine->ShdrAdapter::processData->DataItemMapper.ShdrTokenMapper.operator->DataItemMapper.ShdrTokenMapper.mapTokensToDataItem: Could not find data item: 0.000000 
2024-03-06T09:30:53.442211Z (0x00007fccfd8b9b38) [trace] Connector::reader->Connector::parseSocketBuffer->Connector::processLine->ShdrAdapter::processData->DataItemMapper.ShdrTokenMapper.operator->DataItemMapper.ShdrTokenMapper.mapTokensToDataItem: Could not find data item: y1_axis_interlock

Should the agent ignore the UUID command, or should it consider it as a new device?

wsobel · 2024-03-26T06:26:08Z

It should ignore it. I’ll check to make sure that the new fix did not break something.

emprarthanak · 2024-04-02T09:45:23Z

@wsobel
Built the image using latest code that's been merged and found that

The latest code, now does not work as expected when * uuid: smart_9845_new command is sent and preserveUUID = false. The uuid gets updated and shown in REST output but shows all dataitems as UNAVAILABLE

2024-04-02T09:09:12.261443Z (0x00007fe9490f4640) [trace] Connector::reader->Connector::parseSocketBuffer->Connector::processLine->ShdrAdapter::processData->DataItemMapper.ShdrTokenMapper.operator->DataItemMapper.ShdrTokenMapper.mapTokensToDataItem: Could not find data item: x0_target
2024-04-02T09:09:12.261450Z (0x00007fe9490f4640) [trace] Connector::reader->Connector::parseSocketBuffer->Connector::processLine->ShdrAdapter::processData->DataItemMapper.ShdrTokenMapper.operator->DataItemMapper.ShdrTokenMapper.mapTokensToDataItem: Could not find data item: 0.000000
2024-04-02T09:09:12.261456Z (0x00007fe9490f4640) [trace] Connector::reader->Connector::parseSocketBuffer->Connector::processLine->ShdrAdapter::processData->DataItemMapper.ShdrTokenMapper.operator->DataItemMapper.ShdrTokenMapper.mapTokensToDataItem: Could not find data item: x0_abs

It works fine when preserveUUID = true and * uuid: smart_9845_new command is sent

Thanks

wsobel · 2024-04-02T14:36:22Z

Reopening this issue to find problem.

wsobel · 2024-04-03T21:14:53Z

Made some final changes to support preserve uuid. was not setting preserve in the adapter config for associated device.

emprarthanak · 2024-04-05T08:50:36Z

@wsobel
Observed that the issue still exists as when command * uuid: smart_9845_new command is sent and preserveUUID = false, uuid is updated in REST output. I am sending SHDR data for all data items but status is shown as UNAVAILABLE.

When I refer to agent logs, looks like it is not able to identify data items but it is already defined in XML file

wsobel · 2024-04-05T10:19:33Z

I was not getting that behavior. Can you upload them device xml, the log file, the cfg, and the adapter data. I tried with the previous data and it worked.

emprarthanak · 2024-04-05T10:36:15Z

@wsobel
The previous may be working because the default device defined in the xml is matching with uuid sent as command

Attached xml file, cfg and adapter data for your reference
devices_xml.txt
adapter_test.txt

Devices = devices.xml
 ServerIP = 0.0.0.0
 Port = 5000
 AllowPut = false
 AllowPutFrom = localhost
 ReconnectInterval = 1000
 WorkerThreads = 2
 BufferSize = 17
 MaxAssets = 8096
 IgnoreTimestamps = true
 SchemaVersion = 2.0
 ShdrVersion = 2.0 # Set Default on all Adapters
 JsonVerson = 2.0
 SuppressIPAddress = true
 MonitorConfigFiles = true
 ConversionRequired = false
 UpcaseDataItemValue = true
 EnableSourceDeviceModels = false
 VersionDeviceXml = false
 Pretty = true
 Adapters {
    Saw {
      RealTime = false
      Protocol = shdr
      Host = 192.168.88.105
      Port = 9800
      PreserveUUID = false
   }
}

wsobel · 2024-04-06T20:53:47Z

Checking this again with preserve uuid false.

wsobel added the clarification label Mar 6, 2024

wsobel added the bug label Mar 17, 2024

wsobel linked a pull request Mar 19, 2024 that will close this issue

uuid command handling in agent not as expected #426

Merged

wsobel closed this as completed in #426 Mar 19, 2024

wsobel mentioned this issue Mar 20, 2024

AGENT Device Observationrate stops reporting #388

Closed

wsobel reopened this Mar 26, 2024

wsobel linked a pull request Mar 29, 2024 that will close this issue

Do not change device uuid if preserve uuid is set on the device. #430

Merged

wsobel closed this as completed in #430 Mar 29, 2024

wsobel reopened this Apr 2, 2024

wsobel linked a pull request Apr 3, 2024 that will close this issue

allow preserve uuid in adapter config to associate with device. #433

Merged

wsobel closed this as completed in #433 Apr 3, 2024

wsobel reopened this Apr 6, 2024

wsobel linked a pull request Apr 6, 2024 that will close this issue

419 UUID unavailable when changed #437

Merged

wsobel closed this as completed in #437 Apr 6, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

* uuid command handling in agent not as expected #419

* uuid command handling in agent not as expected #419

EMPreethi commented Mar 6, 2024

wsobel commented Mar 6, 2024 via email

EMPreethi commented Mar 6, 2024

wsobel commented Mar 6, 2024

EMPreethi commented Mar 7, 2024

wsobel commented Mar 7, 2024

wsobel commented Mar 7, 2024

EMPreethi commented Mar 7, 2024

wsobel commented Mar 11, 2024

EMPreethi commented Mar 11, 2024

wsobel commented Mar 11, 2024

EMPreethi commented Mar 26, 2024 •

edited

Loading

wsobel commented Mar 26, 2024 via email

emprarthanak commented Apr 2, 2024 •

edited

Loading

wsobel commented Apr 2, 2024

wsobel commented Apr 3, 2024

emprarthanak commented Apr 5, 2024

wsobel commented Apr 5, 2024

emprarthanak commented Apr 5, 2024

wsobel commented Apr 6, 2024

* uuid command handling in agent not as expected #419

* uuid command handling in agent not as expected #419

Comments

EMPreethi commented Mar 6, 2024

wsobel commented Mar 6, 2024 via email

EMPreethi commented Mar 6, 2024

wsobel commented Mar 6, 2024

EMPreethi commented Mar 7, 2024

wsobel commented Mar 7, 2024

wsobel commented Mar 7, 2024

EMPreethi commented Mar 7, 2024

wsobel commented Mar 11, 2024

EMPreethi commented Mar 11, 2024

wsobel commented Mar 11, 2024

EMPreethi commented Mar 26, 2024 • edited Loading

wsobel commented Mar 26, 2024 via email

emprarthanak commented Apr 2, 2024 • edited Loading

wsobel commented Apr 2, 2024

wsobel commented Apr 3, 2024

emprarthanak commented Apr 5, 2024

wsobel commented Apr 5, 2024

emprarthanak commented Apr 5, 2024

wsobel commented Apr 6, 2024

EMPreethi commented Mar 26, 2024 •

edited

Loading

emprarthanak commented Apr 2, 2024 •

edited

Loading