Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cards without multiverseId #149

Closed
dbottillo opened this issue Dec 2, 2018 · 8 comments
Closed

Cards without multiverseId #149

dbottillo opened this issue Dec 2, 2018 · 8 comments
Labels
Data Issue Something isn't correct Enhancement New feature or request
Milestone

Comments

@dbottillo
Copy link

dbottillo commented Dec 2, 2018

Hi,

I've recently built all the sets and I have discovered that some cards are without a multiverseId.

Sets affected:

  • Anthologies - all cards are without it
  • DeckMasters - all cards are without it
  • Duel Decks: Elves vs Inventors - only the card Darksteel Plate
  • Duel Decks: Zendikar vs Eldrazi - The tokenplant is in the array of cards
  • Duels of the Planeswalkers - all cards are without it
  • Explorers of Ixalan - The token Saproling is in the array of cards
  • From the Vault: Lore - only the card Marit Lage
  • Tenth edition - all cards are without it
  • Ultimate Masters - all cards are without it
  • Unhinged - all cards version (b), eg. Cardpecker (a) has it, Cardpecker (b) doesn't

I've checked all the pre-built json as well at version 4.1.2.
Let me know if you need any more info!

Thanks :)

@tooomm
Copy link
Contributor

tooomm commented Dec 2, 2018

It looks like, as least for UMA, there are no url's either.

@ZeldaZach
Copy link
Member

@tooomm UMA wasn't up on SF when this ticket came out, it's fixed now on their end so I just need a rebuild. Will be done for the next release

@ZeldaZach
Copy link
Member

So I brought this issue up with SF (one of our upstream providers) and they gave some valid input.

The following sets aren't available on Gatherer, so there's no way to associate a multiverseId to them

  • Anthologies
  • DeckMasters
  • Duels of the Planeswalkers
  • Unhinged (The alternate artwork cards are not on Gatherer)

The following sets have been fixed based on your feedback (thank you!):

  • Duel Decks: Elves vs Inventors
  • Ultimate Masters

The following sets I will look into a fix, as it's correct as-is, but the tokens should be moved to the "tokens" array:

  • Duel Decks: Zendikar vs Eldrazi
  • Explorers of Ixalan
  • From the Vault: Lore

I have checked the outputs, but 10th Edition appears to have MultiverseIds correctly associated.


In other news, please make sure you are not using multiverseids as a primary key. I have provided a UUID for that purpose. Not every card has an MID, but every card has a UUID :)

@ZeldaZach ZeldaZach added Data Issue Something isn't correct Enhancement New feature or request labels Dec 2, 2018
@ZeldaZach ZeldaZach modified the milestones: 4.1.2, v4.2 Dec 2, 2018
@dbottillo
Copy link
Author

yes I'm not using the multiverseId as a primary key :) But I'm using that to fetch the card image from gatherer, I'm thinking to maybe use the scryfall API for images in the future so I don't need the multiverseId anymore. I guess I can't display images for those 4 sets if they are not on gatherer 🤷‍♂️

@lebenski
Copy link

lebenski commented Dec 6, 2018

Awesome! When will the next update go out? I'm looking to get Ultimate Masters up on Cube Tutor before release of the set (Saturday) if possible. Thanks for all your hard work on this new version @ZeldaZach

@ZeldaZach
Copy link
Member

@lebenski Didn't know CT was using MTGJSON. Glad you like!

Since you're hoping to get an update on Saturday, I'll put out a fix build today or tomorrow (4.1.3)

@lebenski
Copy link

lebenski commented Dec 6, 2018

@ZeldaZach Much appreciated! :)

@lfgcampos
Copy link

Interested in the new release as well!! =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Data Issue Something isn't correct Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants